Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 578871 - use ISchedulableOperation #18

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Bug 578871 - use ISchedulableOperation #18

merged 1 commit into from
Apr 22, 2022

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Apr 19, 2022

to prevent UI freeze during UNDO

needs
eclipse-platform/eclipse.platform.runtime#30

@jukzi jukzi mentioned this pull request Apr 19, 2022
Merged
@mickaelistria
Copy link
Contributor

That seems much safer, and actually even closer to a generic solution that we could implement in #8 or similar more general proposal !

@jukzi
Copy link
Contributor Author

jukzi commented Apr 21, 2022

3 unrelated errors:

java.lang.AssertionError: 
Warning: Button {Synchronize &scrolling between panes in compare viewers}
	Actual Width -> 0
	Recommended Width -> 357
	at org.eclipse.ui.tests.compare.UIComparePreferencesAuto.testCompareViewersPref(UIComparePreferencesAuto.java:57)


org.eclipse.ui.tests.dialogs.DeprecatedUIPreferencesAuto.testFieldEditorEnablePref
	org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.ui.tests.dialogs.DeprecatedUIPreferencesAuto.testFieldEditorEnablePref(DeprecatedUIPreferencesAuto.java:133)
	

org.eclipse.ui.tests.dialogs.DeprecatedUIPreferencesAuto.testFontEditorsPref
org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.ui.tests.dialogs.DeprecatedUIPreferencesAuto.getPreferenceDialog(DeprecatedUIPreferencesAuto.java:44)
	at org.eclipse.ui.tests.dialogs.DeprecatedUIPreferencesAuto.testFontEditorsPref(DeprecatedUIPreferencesAuto.java:91)

@iloveeclipse
Copy link
Member

Regarding unrelated errors: #30

@jukzi
Copy link
Contributor Author

jukzi commented Apr 22, 2022

2 unrelated errors:
org.eclipse.ui.internal.monitoring.EventLoopMonitorThreadTests.testSeeLongEventInTheMiddleOfNestedCalls
org.eclipse.ui.internal.monitoring.EventLoopMonitorThreadTests.testDoublyNestedEventLogging

A freeze event didn't capture a good range of stack samples (462) expected:<5> but was:<1>
A freeze event didn't capture a good range of stack samples (660) expected:<5> but was:<1>

@jukzi jukzi merged commit d93628b into eclipse-platform:master Apr 22, 2022
@jukzi jukzi deleted the use_ISchedulableOperation branch April 22, 2022 11:27
@iloveeclipse iloveeclipse mentioned this pull request Apr 26, 2022
Merged
jukzi added a commit that referenced this pull request Apr 27, 2022
@jukzi
Bug 578871 - resolve ISchedulableOperation for TriggeredOperations (#18…
7e8c7e6 
…) (#37)

TriggeredOperations hides ISchedulableOperation in triggeredOperation.
see https://user-images.githubusercontent.com/964108/165256257-f796f30f-6d8f-4b1d-9611-863e323f8df6.png
vogella pushed a commit to vogellacompany/eclipse.platform.ui that referenced this pull request Feb 14, 2023
@HannesWell
[RelEng] Perform code freeze period check in GitHub workflow (eclipse…
b5520b5 
…-platform#18)
@WJSchakel WJSchakel mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi left review comments

@iloveeclipse iloveeclipse iloveeclipse left review comments

@mickaelistria mickaelistria mickaelistria left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jukzi @mickaelistria @iloveeclipse @laeubi @EcljpseB0T