IAbstractTextEditorHelpContextIds.FIND_REPLACE_OVERLAY is @since 3.18

[merks]

• New API requires a new minor version

[merks]

@HeikoKlare @Wittmaxi @iloveeclipse

I'm not sure how this slipped past and why the builds don't fail. I had an API error about this in my workspace. It can't be correct that something new is @since 3.17 while the current version is current 3.17.500.

[github-actions]

Test Results

 1 815 files  +  605   1 815 suites  +605   1h 30m 21s ⏱️ + 26m 44s
 7 671 tests ±    0   7 442 ✅ +    2  228 💤  -   3  1 ❌ +1 
24 174 runs  +8 058  23 424 ✅ +7 821  749 💤 +236  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 43328d0. ± Comparison against base commit db983ef.

[HeikoKlare]

Thank you for the correction, @merks!

It seems like the API error introduced in #2045 was not properly processed by the API tooling and instead "only" considered as a Maven issue, for which we have no quality gate defined, such that all PR checks succeed (https://github.com/eclipse-platform/eclipse.platform.ui/runs/27238010348):

<pre><code>1 API problems can&#x27;t be mapped to the compiler log!</code></pre>

See also recent Jenkins logs for master builds (such as https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/master/543/maven-warnings/moduleName.678174556/):

Sorry that I missed that the PR introduced new Maven issues. I will have a better look in future, even if all GitHub checks run green.

[laeubi]

Just wanted to mention that you can see it in the checks overview as well: