Fix lock path computation on Windows and minor simplifications

[HannesWell]

Fixes #2423

[raghucssit]

nio was introduced by https://github.com/eclipse-platform/eclipse.platform.ui/pull/2347/files#diff-6b2613840cdec17a5b7ab1f515650cc101c4637884833261d1353c6e0b9d7535R32.
I think completely getting rid of it safe.

[HannesWell]

Btw. this reminded me of a work that I started a while ago and that I have now made a draft in Equinox:

• Introduce robust URL to java.nio.file.Path conversion eclipse-equinox/equinox#691

When that's available this could be further simplified to (but at the moment this is not possible yet!):

Suggested change

	try {
	return Path.of(URIUtil.toURI(workspaceUrl)).resolve(LOCK_INFO_FILE);
	} catch (URISyntaxException e) {
	throw new IllegalArgumentException(e);
	}
	return URIUtil.toFilePath(workspaceUrl).resolve(LOCK_INFO_FILE);

[github-actions]

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 44m 27s ⏱️ - 2m 3s
 7 711 tests ±0   7 482 ✅ +3  228 💤 ±0  1 ❌  - 3 
24 294 runs  ±0  23 546 ✅ +3  747 💤 ±0  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit 710b70e. ± Comparison against base commit 2ebbbe9.

[iloveeclipse]

Failed test is unrelated and caused by eclipse-platform/eclipse.platform#1592:

java.util.concurrent.ExecutionException: java.util.concurrent.RejectedExecutionException: Thread limit exceeded replacing blocked worker
	at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:605)
	at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:981)
	at org.eclipse.core.internal.filesystem.local.LocalFile.internalDelete(LocalFile.java:335)
	at org.eclipse.core.internal.filesystem.local.LocalFile.lambda$2(LocalFile.java:325)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1428)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.util.concurrent.RejectedExecutionException: Thread limit exceeded replacing blocked worker
	at java.base/java.util.concurrent.ForkJoinPool.tryCompensate(ForkJoinPool.java:1819)
	at java.base/java.util.concurrent.ForkJoinPool.helpJoin(ForkJoinPool.java:1852)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:440)
	at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:979)
	at org.eclipse.core.internal.filesystem.local.LocalFile.internalDelete(LocalFile.java:335)
	at org.eclipse.core.internal.filesystem.local.LocalFile.lambda$2(LocalFile.java:325)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1428)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:436)
	at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:979)
	... 8 more

[iloveeclipse]

Thanks, checked on Windows, works now.