Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent JobManager UI freeze when waiting for a rule in the UI Thread #40

Merged

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Apr 27, 2022

Just a draft for @jukzi

@laeubi
Copy link
Contributor Author

laeubi commented Apr 27, 2022

By the way: for this to work more smooth, the default timed wait of 250ms in the Job API might be to long and could potentially feel lagging, I probably would reduce that to 100ms.

@vogella
Copy link
Contributor

vogella commented Apr 27, 2022

By the way: for this to work more smooth, the default timed wait of 250ms in the Job API might be to long and could potentially feel lagging, I probably would reduce that to 100ms.

Sounds fine, but please create a new PR for this.

@laeubi laeubi force-pushed the impl_e3_progressmanager branch from e982546 to 86d3c47 Compare May 1, 2022 05:26
@laeubi laeubi linked an issue May 1, 2022 that may be closed by this pull request
@laeubi laeubi changed the title Impl of ProgressProvider#forMonitor Prevent JobManager UI freeze when waiting for a rule in the UI Thread May 1, 2022
@laeubi laeubi requested a review from jukzi May 1, 2022 05:28
@laeubi laeubi marked this pull request as ready for review May 1, 2022 05:28
@laeubi laeubi requested a review from iloveeclipse May 1, 2022 05:28
@laeubi laeubi mentioned this pull request May 1, 2022
@laeubi laeubi force-pushed the impl_e3_progressmanager branch from 86d3c47 to a1a91f3 Compare May 1, 2022 09:07
@mickaelistria
Copy link
Contributor

Code looks very good. Can you please rework the commit message to make it more general and not only focus on JobManager? I think this code here is supposed to avoid UI freezes for most progress monitors, JobManager is just 1 consumer of those. This change may also require a rebase for the build to work.

@laeubi
Copy link
Contributor Author

laeubi commented May 2, 2022

I only found this method used in the JobManger, can you give a reference where it is used elsewhere?

@mickaelistria
Copy link
Contributor

You're right, sorry, I was confused with org.eclipse.core.internal.utils.Policy.monitorFor(). So it seems fine to keep this commit message as it.

@laeubi
Copy link
Contributor Author

laeubi commented May 2, 2022

I rebased the change now.

@mickaelistria
Copy link
Contributor

"on project org.eclipse.e4.ui.progress: Unqualified OSGi version 0.3.400.qualifier must match unqualified Maven version 0.3.300-SNAPSHOT for SNAPSHOT builds -"

@laeubi laeubi force-pushed the impl_e3_progressmanager branch from 2822bb0 to 28c6a79 Compare May 2, 2022 11:52
@laeubi
Copy link
Contributor Author

laeubi commented May 2, 2022

Next try :-\

@mickaelistria mickaelistria merged commit 2077a79 into eclipse-platform:master May 2, 2022
@mickaelistria
Copy link
Contributor

Thanks! That's a good change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent JobManager UI freeze when waiting for a rule in the UI Thread
3 participants