-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent JobManager UI freeze when waiting for a rule in the UI Thread #40
Prevent JobManager UI freeze when waiting for a rule in the UI Thread #40
Conversation
By the way: for this to work more smooth, the default timed wait of 250ms in the Job API might be to long and could potentially feel lagging, I probably would reduce that to 100ms. |
Sounds fine, but please create a new PR for this. |
e982546
to
86d3c47
Compare
86d3c47
to
a1a91f3
Compare
Code looks very good. Can you please rework the commit message to make it more general and not only focus on JobManager? I think this code here is supposed to avoid UI freezes for most progress monitors, JobManager is just 1 consumer of those. This change may also require a rebase for the build to work. |
I only found this method used in the |
You're right, sorry, I was confused with |
a1a91f3
to
2822bb0
Compare
I rebased the change now. |
"on project org.eclipse.e4.ui.progress: Unqualified OSGi version 0.3.400.qualifier must match unqualified Maven version 0.3.300-SNAPSHOT for SNAPSHOT builds -" |
2822bb0
to
28c6a79
Compare
Next try :-\ |
Thanks! That's a good change! |
Just a draft for @jukzi