Skip to content

Commit

Permalink
testFirstTabIsActivatedByDefault is no more passing with SWT fix under
Browse files Browse the repository at this point in the history
  • Loading branch information
deepika-u committed May 7, 2024
1 parent 692c8fa commit 93fbf78
Showing 1 changed file with 6 additions and 11 deletions.
Original file line number Diff line number Diff line change
@@ -1183,10 +1183,7 @@ public boolean canSave() {
* @return if the dialog can launch in its current state
*/
public boolean canLaunch() {
if(fInitializingTabs) {
return false;
}
if (getWorkingCopy() == null) {
if (fInitializingTabs || (getWorkingCopy() == null)) {
return false;
}
try {
@@ -1274,11 +1271,7 @@ private boolean hasMultipleDelegates() {
* @return the error message for the tab
*/
public String getErrorMesssage() {
if (fInitializingTabs) {
return null;
}

if (getWorkingCopy() == null) {
if (fInitializingTabs || (getWorkingCopy() == null)) {
return null;
}
try {
@@ -1455,12 +1448,14 @@ protected void handleTabSelected() {
fCurrentTabIndex = fTabFolder.getSelectionIndex();

ILaunchConfigurationTab[] tabs = getTabs();
if (previousTabIndex == fCurrentTabIndex || tabs == null || tabs.length == 0
if (tabs == null || tabs.length == 0
|| previousTabIndex > (tabs.length - 1)) {
return;
}

propagateTabDeactivation(previousTabIndex);
if (previousTabIndex != fCurrentTabIndex) {
propagateTabDeactivation(previousTabIndex);
}

propagateTabActivation();
}

0 comments on commit 93fbf78

Please sign in to comment.