Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix Cut Off Label on Welcome Page" #1013

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

BeckerWdf
Copy link
Contributor

Reverts #745

This caused a regression. See eclipse-platform/eclipse.platform.ui#1408
I don't know how I could overlook this.

@BeckerWdf BeckerWdf self-assigned this Dec 13, 2023
@BeckerWdf BeckerWdf added this to the 4.31 M1 milestone Dec 13, 2023
Copy link
Contributor

Test Results

     551 files   -   43       551 suites   - 43   59m 6s ⏱️ - 10m 40s
  3 855 tests ±    0    3 836 ✔️ ±    0    19 💤 ±0  0 ±0 
11 785 runs   - 386  11 633 ✔️  - 386  152 💤 ±0  0 ±0 

Results for commit 79af6e1. ± Comparison against base commit c803d0c.

@BeckerWdf
Copy link
Contributor Author

error on windows:

Error:  Failed to execute goal org.eclipse.tycho:tycho-p2-plugin:4.0.5-SNAPSHOT:p2-metadata-default (default-p2-metadata-default) on project org.eclipse.compare.core: Execution default-p2-metadata-default of goal org.eclipse.tycho:tycho-p2-plugin:4.0.5-SNAPSHOT:p2-metadata-default failed: Error trying to download org.eclipse.compare.core version 3.8.400.v20231212-1100 from https://download.eclipse.org/eclipse/updates/4.31-I-builds/I20231212-1800:
Error:  download from https://download.eclipse.org/eclipse/updates/4.31-I-builds/I20231212-1800/plugins/org.eclipse.compare.core_3.8.400.v20231212-1100.jar failed: File element in parameter 'destFile' already exists: 'C:\Users\runneradmin\.m2\repository\.cache\tycho\https\download.eclipse.org\eclipse\updates\4.31-I-builds\I20231212-1800\plugins\org.eclipse.compare.core_3.8.400.v20231212-1100.jar'

looks unrelated

@BeckerWdf BeckerWdf merged commit edac22f into master Dec 13, 2023
15 of 17 checks passed
@BeckerWdf BeckerWdf deleted the revert-745-welcome branch December 13, 2023 16:06
Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant