Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISystemInformation.Section OSGi component property type #1586

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add ISystemInformation.Section OSGi component property type #1586

merged 1 commit into from
Oct 15, 2024
+44 −30

Conversation

HannesWell
Copy link
Member

This annotation simplifies the specification of the 'section' service property for ISystemInformation
implementations and makes it more robust:

@Component(service = ISystemInformation.class)
@ISystemInformation.Section(AboutSections.SECTION_SYSTEM_PROPERTIES)
public class ExampleInformation implements ISystemInformation {

@HannesWell HannesWell requested a review from ruspl-afed October 13, 2024 10:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 13, 2024 •
edited
Loading

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 27m 16s ⏱️ - 1m 20s
 4 170 tests ±0   4 148 ✅ ±0   22 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 943 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit 42287d6. ± Comparison against base commit be89385.

♻️ This comment has been updated with latest results.

@HannesWell
Add ISystemInformation.Section OSGi component property type
42287d6 
This annotation simplifies the specification of the
'section' service property for ISystemInformation
implementations and makes it more robust:
'''
@component(service = ISystemInformation.class)
@ISystemInformation.Section(AboutSections.SECTION_SYSTEM_PROPERTIES)
public class ExampleInformation implements ISystemInformation {
'''
@HannesWell HannesWell force-pushed the add-ISystemInformation.Section-property-type branch from 41ff1f6 to 42287d6 Compare October 14, 2024 20:16
ruspl-afed
ruspl-afed approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for upgrading this @HannesWell

@HannesWell
Copy link
Member Author

You're welcome and thank you for the review.

@HannesWell HannesWell merged commit 3cef3f3 into eclipse-platform:master Oct 15, 2024
17 checks passed
@HannesWell HannesWell deleted the add-ISystemInformation.Section-property-type branch October 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruspl-afed ruspl-afed ruspl-afed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannesWell @ruspl-afed