Update of the FAQ Log entry #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogella
force-pushed
the
update_of_faq_log_entry
branch
from
c1a586d to
715490c
Compare
|
@HannesWell WDTY? @thahnen FYI, we like to see more PR from you (also code related if you find the time). |
vogella
force-pushed
the
update_of_faq_log_entry
branch
from
715490c to
7ea6b8b
Compare
merks
reviewed
Nov 20, 2024
| ... | ||
| public static void test(){ | ||
| try { | ||
| log("Eclipse Style Logging"); | ||
| ILog.get().info("Starting"); |
There was a problem hiding this comment.
Maybe it's not a good idea to use tabs.
vogella
force-pushed
the
update_of_faq_log_entry
branch
from
7ea6b8b to
f1c8ca0
Compare
merks
reviewed
Nov 20, 2024
| try { | ||
| log("Eclipse Style Logging"); | ||
| // do something that may cause an exception | ||
| } | ||
| catch(Exception e){ |
There was a problem hiding this comment.
Nit.
Suggested change
| catch(Exception e){ | |
| catch (Exception e){ |
Lets promote ILog.get() instead Platform.getLog():
vogella
force-pushed
the
update_of_faq_log_entry
branch
from
f1c8ca0 to
ba30f2d
Compare
|
Ignoring freeze as this is only online documentation |
HannesWell
approved these changes
Nov 20, 2024
| You can write any kind of IStatus object to the log file, including a MultiStatus if you have hierarchies of information to display. If you create your own subclass of the utility class Status, you can override the getMessage method to return extra information to be displayed in the log file. Many plug-ins add utility classes for writing messages and errors to the log: | ||
|
|
||
| import org.eclipse.core.runtime.Status; | ||
| import org.eclipse.core.runtime.ILog; | ||
| ... | ||
| public class MyLogger { | ||
| ... | ||
| private static final Bundle BUNDLE = FrameworkUtil.getBundle(MyLogger.class); |
There was a problem hiding this comment.
Is this line still necessary?
At least while viewing this on the phone I can't see a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets promote ILog.get() instead Platform.getLog():