Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark IPlatformConfiguration/Factory for removal #1651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 15, 2024

These interfaces are currently only used by ConfiguratorUtils that is already marked for removal on 2024-03

See

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

update/org.eclipse.update.configurator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 45b81e4ebffd8eccebfa0078ff62dcdb491a701c Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 15 Dec 2024 06:10:06 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
index 64ab4e2541..029cfe32d5 100644
--- a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
+++ b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.update.configurator; singleton:=true
-Bundle-Version: 3.5.500.qualifier
+Bundle-Version: 3.5.600.qualifier
 Bundle-Activator: org.eclipse.update.internal.configurator.ConfigurationActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Contributor

vogella commented Dec 15, 2024

LGTM

Copy link
Contributor

github-actions bot commented Dec 15, 2024

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 34m 2s ⏱️ + 5m 53s
 4 170 tests ±0   4 148 ✅ ±0   22 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 943 ✅ ±0  164 💤 ±0  0 ❌ ±0 

Results for commit e2aa858. ± Comparison against base commit ca5ed8a.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor

vogella commented Dec 18, 2024

@laeubi looks like this adds additional warnings (for example The type IPlatformConfiguration.IFeatureEntry has been deprecated and marked for removal) to the build and fails the quality gate. Can you have to look? IIRC mark for removal should be done in M1

@laeubi
Copy link
Contributor Author

laeubi commented Dec 18, 2024

@vogella this is JDT bug:

eclipse-jdt/eclipse.jdt.core#3402

so we can not really do much than to accept the new warnings and hope for the best :-)

@vogella
Copy link
Contributor

vogella commented Dec 18, 2024

@vogella this is JDT bug:

eclipse-jdt/eclipse.jdt.core#3402

so we can not really do much than to accept the new warnings and hope for the best :-)

In this case I suggest to merge

(I assume this will update also the quality gate and future PR will use the new warning number created by this JDT bug ).

These interfaces are currently only used by ConfiguratorUtils that is
already marked for removal on 2024-03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants