Finish o.e.help.base move to Lucene 10 and Java 21 #1659
Merged
+39
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce chances for surprises at runtime.
It's already transitive dependency through Lucene.
In Java 21 Thread.stop simply throws UnsupportedOperationException and ThreadDeath was thrown only from that method in older JVM versions.
|
This all makes good sense. Thanks. 👍 |
|
There are 20 new code warnings - all about deprecated URL methods/constructors usage which have been around since Java 20 but not reported due to older JVM. |
|
FYI, note that changing the URL methods being called to fix the deprecation warnings is really dangerous. The handling of error cases is different. You can create a URL with a space, but you cannot create a URI with a space... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.