Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.harness: Delete reference to deleted extension point #638 #650

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Aug 30, 2023

The SaveManagerTest test can manually started with org.eclipse.core.tests.resources.session.SaveParticipantTest

#638

@jukzi jukzi linked an issue Aug 30, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Test Results

       42 files  ±0         42 suites  ±0   1h 4m 25s ⏱️ + 13m 48s
  3 768 tests ±0    3 763 ✔️  - 1    3 💤 ±0  2 +1 
11 307 runs  ±0  11 276 ✔️  - 1  27 💤 ±0  4 +1 

For more details on these failures, see this check.

Results for commit ad5e7bd. ± Comparison against base commit f385650.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing plugin.xml due to non-existent extension point is fine.
The plugin.xml has to be removed from the bin.includes of the build.properties as well.

@jukzi
Copy link
Contributor Author

jukzi commented Sep 1, 2023

The plugin.xml has to be removed from the bin.includes of the build.properties as well.

thanks

…tform#638

The SaveManagerTest test can manually started with
org.eclipse.core.tests.resources.session.SaveParticipantTest

eclipse-platform#638
@jukzi jukzi merged commit 90105ec into eclipse-platform:master Sep 11, 2023
@jukzi jukzi deleted the harness branch September 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown extension point: 'org.eclipse.core.tests.harness.tests'
3 participants