Improve error message and fail behavior of ParallelBuildChainTest #657 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 42 files ±0 42 suites ±0 54m 22s ⏱️ - 4m 15s For more details on these failures, see this check. Results for commit 1bbae07. ± Comparison against base commit 90105ec. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-657
branch
5 times, most recently
from
8aa9977 to
6140002
Compare
…ipse-platform#657 The ParallelBuildChainTest has some flaws in error message design and failure handling, which are addressed by this change: 1. The timeout for builds to start/finish is higher than the execution time of a long running build. Thus in case builds are unexpectedly not run in parallel, the assertion for timely build start/finish is not evaluated as expected. 2. In case an error occurs before starting a build operation, the number of expected builds in the TimerBuilder may be higher than the number of builds that will every be executed. Since the TimerBuilder abortion tries to wait for all expected builds indefinitely, the operation (and thus test tear down) may never terminate.
HeikoKlare
force-pushed
the
issue-657
branch
from
6140002 to
1bbae07
Compare
|
Failing test documented in #668. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ParallelBuildChainTesthas some flaws in error message design and failure handling, which are addressed by this change: