Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data setup in ParallelBuildChainTest explicit per test case #659 #660

Merged

Conversation

HeikoKlare
Copy link
Contributor

Define number of projects and number of allowed parallel builds per test case instead of for the whole test class to ensure that test cases can use different values for different purposes. Improve consistency and readability by using explicitly defined and equal values for number of projects and number of parallel builds.

This is a preparatory refactoring for providing a regression test for #659.

Contributes to #659.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Test Results

       42 files  ±0         42 suites  ±0   50m 14s ⏱️ - 2m 2s
  3 770 tests ±0    3 766 ✔️  - 1    3 💤 ±0  1 +1 
11 313 runs  ±0  11 285 ✔️  - 1  27 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit cb67837. ± Comparison against base commit 6797ba2.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the issue-659-refactoring branch 2 times, most recently from e46ba7a to 5024cc3 Compare September 11, 2023 10:37
@HeikoKlare HeikoKlare marked this pull request as ready for review September 11, 2023 11:36
…pse-platform#659

Define number of projects and number of allowed parallel builds per test
case instead of for the whole test class to ensure that test cases can
use different values for different purposes. Improve consistency and
readability by using explicitly defined and equal values for number of
projects and number of parallel builds.

Contributes to
eclipse-platform#659.
@HeikoKlare HeikoKlare force-pushed the issue-659-refactoring branch from 5024cc3 to cb67837 Compare September 12, 2023 07:11
@HeikoKlare
Copy link
Contributor Author

Failing test is documented in #488.

@HeikoKlare HeikoKlare merged commit 418fcfc into eclipse-platform:master Sep 12, 2023
12 of 14 checks passed
@HeikoKlare HeikoKlare deleted the issue-659-refactoring branch September 12, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant