Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyManager2 iterates the tree for infinite depth for deleting/moving an IFile #468 #693

Conversation

lathapatil
Copy link
Contributor

Changing the depth from infinite to zeroth level for IFile resource deletion

Fixes #468

deleting/moving an IFile eclipse-platform#468

Changing the depth from infinite to zeroth level for IFile resource
deletion

Fixes eclipse-platform#468
@iloveeclipse iloveeclipse force-pushed the Issues/468_IFile_delete_ZerothDepth branch from 34b98f7 to c3b3182 Compare September 20, 2023 16:29
@iloveeclipse
Copy link
Member

The change makes sense.
On Linux I see test times around 35 seconds without the patch and 20 seconds with patch.
I've rebased branch to see if there were any errors, I was unable to see jenkins PR state.

@github-actions
Copy link
Contributor

Test Results

       42 files  ±0         42 suites  ±0   53m 38s ⏱️ - 1m 52s
  3 776 tests +1    3 773 ✔️ +1    3 💤 ±0  0 ±0 
11 331 runs  +3  11 304 ✔️ +3  27 💤 ±0  0 ±0 

Results for commit c3b3182. ± Comparison against base commit f10dfa5.

@iloveeclipse iloveeclipse merged commit 5e0a997 into eclipse-platform:master Sep 20, 2023
14 checks passed
@lathapatil lathapatil deleted the Issues/468_IFile_delete_ZerothDepth branch September 21, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance] PropertyManager2 iterates the tree for infinite depth for deleting/moving an IFile
2 participants