Use equinox preferences APIs in RefreshManager class #497 #695
Conversation
Test Results 42 files ±0 42 suites ±0 53m 19s ⏱️ - 3m 2s For more details on these failures, see this check. Results for commit 2acca52. ± Comparison against base commit 229beea. ♻️ This comment has been updated with latest results. |
akurtakov
force-pushed
the
Issues/497_Use_Equinox_preferences_API
branch
from
f5df33b to
d269de5
Compare
HeikoKlare
force-pushed
the
Issues/497_Use_Equinox_preferences_API
branch
from
6928922 to
a79e451
Compare
There was a problem hiding this comment.
Thanks for the adaptation! The change looks good to me.
@lathapatil Could you address the minor comment concerning the copyright information update? And after that, is the PR ready to merge from your side?
| @@ -12,9 +12,11 @@ | |||
| * IBM - Initial API and implementation | |||
| * Christoph Läubrich - Issue #84 - RefreshManager access ResourcesPlugin.getWorkspace in the init phase | |||
| * - Issue #97 - RefreshManager.manageAutoRefresh calls ResourcesPlugin.getWorkspace before the Workspace is fully open | |||
| * Latha Patil(ETAS GmbH) - GitHub Issue #497- Get rid of deprecated org.eclipse.core.runtime.Preferences in platform code | |||
There was a problem hiding this comment.
Adding the contribution information is optional. If you want to keep it, please also change the year in the first line from 2022 to 2023.
Nitpicky: I would prefer to format the copyright line consistent with the existing ones, i.e., only containing "Issue ..." instead of "GitHub Issue ...".
There was a problem hiding this comment.
Thanks for the review . I will adopt the changes and provide for re-review
lathapatil
force-pushed
the
Issues/497_Use_Equinox_preferences_API
branch
from
12b1f53 to
22bf85b
Compare
|
Looks good, thanks! One final thing: Could you please squash the two commits into a single one, @lathapatil? |
…#497 Replacing deprecated Preferences API usage with modern Equinox Preferences API. Partially fixes eclipse-platform#497 Updated copyright header as per review comments Squash Commits
lathapatil
force-pushed
the
Issues/497_Use_Equinox_preferences_API
branch
from
22bf85b to
2acca52
Compare
Its done ! |
Replacing deprecated Preferences API usage with modern Equinox Preferences API.
Partially fixes
#497