Add generics to new org.eclipse.core.resource.undo.snapshots #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robstryker Can you please review this? I try to add stronger typing so clients should deal less with cast and potential ClassCastException |
|
Investigating. Thanks for the PR. |
|
I'm fine with a +1 on this. If you think this is better design I'm inclined to agree that updating the code to use more modern features is to our benefit. |
|
Thanks. Would it be OK to merge now? |
|
should be fine |
mickaelistria
merged commit 26702b2
into
eclipse-platform:master
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.