Update URL following merge into platform of other repos #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm guessing this build will fail as all bundles probably need version bumped? |
akurtakov
reviewed
Sep 20, 2023
jonahgraham
force-pushed
the
update-url
branch
from
6cabfe9 to
982ebbf
Compare
jonahgraham
changed the title
|
And it failed because submodules are not using the parent from this repo but define eclipse-platform-parent directly. This should be fixed too. |
…epos Amongst possibly other things I think this is the URL that is embedded in MANFIFEST.MF as the location the bundles are stored in git. The proper value for this comes from the parent pom, which needed to be updated for a couple of the modules too.
jonahgraham
force-pushed
the
update-url
branch
from
982ebbf to
ca38863
Compare
Thanks for the pointer - I think I made the appropriate update. |
|
THanks Jonah! These "small" fixes really add up . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amongst possibly other things I think this is the URL that is embedded in MANFIFEST.MF as the location the bundles are stored in git. The proper value for this comes from the parent pom.