Improve test isolation and performance of BeginEndRuleTests #725 #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
issue-725
branch
from
b3cf68a to
7b18972
Compare
…latform#725 Several test cases in BeginEndRuleTests cannot successfully be executed standalone. When starting a test environment, i.e., a workspace, several jobs are running on startup. These jobs trigger the JobChangeAdapter registered in some test cases, which does not properly filter the events and leads to faulty test results. In addition, the test cases rely on sleep operations, which waste execution time and at the same time are prone to fail randomly. This change rewrite the according test cases: - Corrects job event filtering for proper test isolation - Replaces sleep operations with join operation on jobs and barriers to improve performance and reduce the risk of random failures - Improves assertions and their messages Fixes eclipse-platform#725.
HeikoKlare
force-pushed
the
issue-725
branch
from
7b18972 to
4d65c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several test cases in
BeginEndRuleTestscannot successfully be executed standalone. When starting a test environment, i.e., a workspace, several jobs are running on startup. These jobs trigger theJobChangeAdapterregistered in some test cases, which does not properly filter the events and leads to faulty test results. In addition, the test cases rely on sleep operations, which waste execution time and at the same time are prone to fail randomly.This change rewrite the according test cases:
Fixes #725.