Fix test for save state cleanup on snapshot save / bug 297635 #460 #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 36 files - 6 36 suites - 6 48m 57s ⏱️ - 6m 4s Results for commit 7afdb42. ± Comparison against base commit 0b0eff5. This pull request removes 1036 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
fedejeanne
reviewed
Oct 13, 2023
...eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/regression/Bug_297635.java
Outdated
Show resolved
Hide resolved
...eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/regression/Bug_297635.java
Outdated
Show resolved
Hide resolved
...lipse.core.tests.resources/src/org/eclipse/core/tests/resources/session/AllSessionTests.java
Outdated
Show resolved
Hide resolved
...eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/regression/Bug_297635.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
issue-460
branch
2 times, most recently
from
69978f2 to
f9a5b76
Compare
fedejeanne
reviewed
Oct 13, 2023
...eclipse.core.tests.resources/src/org/eclipse/core/tests/resources/regression/Bug_297635.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
issue-460
branch
2 times, most recently
from
19dbe22 to
cd75c85
Compare
|
Looks good :-) |
…-platform#460 The existing test TestBug297635 relies on reflection to test some internal state change of the SavedState class that saves temporary states until some save operation. The test was prone to fail because it relied on internal state changes that depend an specific overall system state (e.g., have an unsaved workspace state, so that no concurrent automatic snapshot save is allowed to occur during test execution). It used reflection to access an internal, highly volatile state. The bug for which the test case serves as a regression test was due to missing cleanup triggered by SavedState.forgetSavedTree(). Instead of checking for internal state changes performed by the cleanup, the rewritten test only checks for a call of the according method. To this end, it temporarily inserts a spy on the SaveManager. Since a Workspace and SaveManager are not easy to set up in an isolated way for testing purposes, the test still relies on reflection, but only to inject a spy on the SaveManager rather than to validate internal states. Since the test is not required to be run as a session test anymore, it is moved to the ordinary regression resource tests. Fixes eclipse-platform#460.
|
Failing test is unrelated and documented in #744. In addition, checks are only failing because of an API tooling issue, see eclipse-pde/eclipse.pde#782. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test
TestBug297635relies on reflection to test some internal state change of theSavedStateclass that saves temporary states until some save operation. The test was prone to fail because it relied on internal state changes that depend an specific overall system state (e.g., have an unsaved workspace state, so that no concurrent automatic snapshot save is allowed to occur during test execution). It used reflection to access an internal, highly volatile state.The bug for which the test case serves as a regression test was due to missing cleanup triggered by
SavedState.forgetSavedTree(). Instead of checking for internal state changes performed by the cleanup, the rewritten test only checks for a call of the according method. To this end, it temporarily inserts a spy on theSaveManager. Since aWorkspaceandSaveManagerare not easy to set up in an isolated way for testing purposes, the test still relies on reflection, but only to inject a spy on theSaveManagerrather than to validate internal states.Since the test is not required to be run as a session test anymore, it is moved to the ordinary regression resource tests.
Fixes #460.