Modernized help UI prototype: Refactor JavaScript code #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures do not seem to me to be related to this change. |
howlger
force-pushed
the
patch-before-1
branch
2 times, most recently
from
54713fd to
b2647dc
Compare
|
To review this change, the modernized help UI has to be enabled via the Java property |
Refactor JavaScript code for better readability. No functional changes. See also eclipse-platform#735 (review)
iloveeclipse
force-pushed
the
patch-before-1
branch
from
b2647dc to
f17c6bc
Compare
|
@howlger : is this still relevant? |
:-) If so, let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor JavaScript code for better readability. No functional changes.
See also #735 (review)