Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Ant UI performance tests to JUnit 5 #751

Merged

Conversation

HeikoKlare
Copy link
Contributor

The performance tests in org.eclipse.ant.tests.ui still rely on the JUnit 3 PerformanceTestCase. In addition, one test class is missing in the according test suite.

  • Migrates all Ant UI performance tests and test suites to JUnit 5
  • Adds the missing OpenLaunchConfigurationDialogTest performance test to the performance test suite

SeparateVMTests as part of the performance test suite is not yet migrated to JUnit 5, as it is derived from an ordinary Ant UI test, which is still based on JUnit 3. This will be migrated once the other, ordinary Ant UI tests are migrated to JUnit 4 / 5.

Note that the performance tests are not executed in CI builds, so the change will probably not have any effect that is automatically validated.

The performance tests in org.eclipse.ant.tests.ui still rely on the
JUnit 3 PerformanceTestCase. In addition, one test class is missing in
the according test suite.

* Migrates all Ant UI performance tests and test suites to JUnit 5
* Adds the missing OpenLaunchConfigurationDialogTest performance test to
the performance test suite
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Test Results

       51 files  +     15         51 suites  +15   1h 2m 34s ⏱️ + 13m 59s
  3 773 tests +1 030    3 770 ✔️ +1 031    3 💤 ±0  0  - 1 
11 337 runs  +3 105  11 310 ✔️ +3 106  27 💤 ±0  0  - 1 

Results for commit a94f4cf. ± Comparison against base commit cfb3c5f.

This pull request removes 229 and adds 1259 tests. Note that renamed tests count towards both.
org.eclipse.ant.tests.ui.APITests ‑ testCompareJavaVersions
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsComplexHierarchyAlias
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsComplexHierarchyMisc
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsComplexHierarchyNoAlias
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsExternalFiles
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsPerformance
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsSimpleHierarchyAlias
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetIncludeTargetsSimpleHierarchyNoAliases
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetTargetsLaunchConfiguration
org.eclipse.ant.tests.ui.AntUtilTests ‑ testGetTargetsLaunchConfigurationMinusD
…
AntUITests org.eclipse.ant.tests.ui.APITests ‑ testCompareJavaVersions
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testCreateClassloader1
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetCopyOfReferences1
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetProperties1
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetProprty1
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetProprty2
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetReference1
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetReference2
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetReference3
AntUITests org.eclipse.ant.tests.ui.ModelProjectTests ‑ testGetReferences1
…

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review October 20, 2023 08:24
@akurtakov akurtakov merged commit 304be62 into eclipse-platform:master Oct 26, 2023
14 checks passed
@HeikoKlare HeikoKlare deleted the ant-ui-performance-tests-junit5 branch October 26, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants