Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4690 Add unit test for path iteration #4691

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

JervenBolleman
Copy link
Contributor

GitHub issue resolved: #4690

Briefly describe the changes proposed in this PR:

Add some unit tests, to give more confidence in future improvements.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@JervenBolleman JervenBolleman self-assigned this Jul 27, 2023
@JervenBolleman JervenBolleman merged commit 93e27e1 into main Jul 28, 2023
6 checks passed
@JervenBolleman JervenBolleman deleted the GH-4690-Unit-test-for-path-iteration branch July 28, 2023 07:41
@@ -0,0 +1,155 @@
/*******************************************************************************
* Copyright (c) 2019 Eclipse RDF4J contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update this to 2023?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am sorry for that oversight.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for PropertyPathEvaluation
2 participants