Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4646 remove intermediate join variables #4695

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

JervenBolleman
Copy link
Contributor

GitHub issue resolved: #4646

Briefly describe the changes proposed in this PR:

The PathIteration adds variables to the binding set that are not known ahead of time and not needed after the pathiteration logic is done. These should be stripped out and not propegated.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@JervenBolleman JervenBolleman self-assigned this Jul 28, 2023
@JervenBolleman JervenBolleman force-pushed the GH-4646-remove-intermediate-joins branch 3 times, most recently from 5c19780 to d445a3d Compare July 28, 2023 15:16
Copy link
Contributor

@abrokenjester abrokenjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - great detective work!

@JervenBolleman JervenBolleman changed the title GH-4646 remove intermediate joins GH-4646 remove intermediate join variables Aug 21, 2023
@JervenBolleman
Copy link
Contributor Author

I will merge it into main now, for 5.x I hope to make a better solution. That still needs work, and expanded test coverage.

@JervenBolleman JervenBolleman merged commit 7ad3ebf into main Aug 21, 2023
6 checks passed
@JervenBolleman JervenBolleman deleted the GH-4646-remove-intermediate-joins branch August 21, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError in ArrayBindingSet on intermediate_join after upgrade from 3.7.7 to 4.2.3
2 participants