Deletion of Keybinding Context classes

- `Blame Keybinding context` deletion
- `Terminal Keybinding context` deletion
- `Console Keybinding Context` deletion
- `Debug Keybinding Context` deletion
- `Editor Keybinding Context` deletion
- `Notification Keybinding Contribution` Deletetion
- `Navigator Keybinding Context` deletion

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>

packages/console/src/browser/console-frontend-module.ts

@@ -16,19 +16,14 @@
 
 import { ContainerModule } from '@theia/core/shared/inversify';
 import { CommandContribution, MenuContribution } from '@theia/core';
-import { FrontendApplicationContribution, KeybindingContext, KeybindingContribution } from '@theia/core/lib/browser';
+import { FrontendApplicationContribution, KeybindingContribution } from '@theia/core/lib/browser';
 import { ConsoleContribution } from './console-contribution';
 import { ConsoleManager } from './console-manager';
-import { ConsoleInputFocusContext, ConsoleNavigationBackEnabled, ConsoleNavigationForwardEnabled, ConsoleContentFocusContext } from './console-keybinding-contexts';
 
 import '../../src/browser/style/index.css';
 
 export default new ContainerModule(bind => {
     bind(ConsoleManager).toSelf().inSingletonScope();
-    bind(KeybindingContext).to(ConsoleInputFocusContext).inSingletonScope();
-    bind(KeybindingContext).to(ConsoleContentFocusContext).inSingletonScope();
-    bind(KeybindingContext).to(ConsoleNavigationBackEnabled).inSingletonScope();
-    bind(KeybindingContext).to(ConsoleNavigationForwardEnabled).inSingletonScope();
     bind(ConsoleContribution).toSelf().inSingletonScope();
     bind(FrontendApplicationContribution).toService(ConsoleContribution);
     bind(CommandContribution).toService(ConsoleContribution);

packages/debug/src/browser/debug-frontend-module.ts

@@ -22,7 +22,7 @@ import { DebugWidget } from './view/debug-widget';
 import { DebugPath, DebugService } from '../common/debug-service';
 import {
     WidgetFactory, WebSocketConnectionProvider, FrontendApplicationContribution,
-    bindViewContribution, KeybindingContext
+    bindViewContribution
 } from '@theia/core/lib/browser';
 import { DebugSessionManager } from './debug-session-manager';
 import { DebugResourceResolver } from './debug-resource';
@@ -39,7 +39,6 @@ import { DebugFrontendApplicationContribution } from './debug-frontend-applicati
 import { DebugConsoleContribution } from './console/debug-console-contribution';
 import { BreakpointManager } from './breakpoint/breakpoint-manager';
 import { DebugEditorService } from './editor/debug-editor-service';
-import { InDebugModeContext, BreakpointWidgetInputFocusContext, BreakpointWidgetInputStrictFocusContext } from './debug-keybinding-contexts';
 import { DebugEditorModelFactory, DebugEditorModel } from './editor/debug-editor-model';
 import { bindDebugPreferences } from './debug-preferences';
 import { DebugSchemaUpdater } from './debug-schema-updater';
@@ -100,9 +99,6 @@ export default new ContainerModule((bind: interfaces.Bind) => {
     bind(DebugResourceResolver).toSelf().inSingletonScope();
     bind(ResourceResolver).toService(DebugResourceResolver);
 
-    bind(KeybindingContext).to(InDebugModeContext).inSingletonScope();
-    bind(KeybindingContext).to(BreakpointWidgetInputFocusContext).inSingletonScope();
-    bind(KeybindingContext).to(BreakpointWidgetInputStrictFocusContext).inSingletonScope();
     bindViewContribution(bind, DebugFrontendApplicationContribution);
     bind(FrontendApplicationContribution).toService(DebugFrontendApplicationContribution);
     bind(TabBarToolbarContribution).toService(DebugFrontendApplicationContribution);

packages/editor/src/browser/editor-frontend-module.ts

@@ -19,13 +19,12 @@ import '../../src/browser/language-status/editor-language-status.css';
 
 import { ContainerModule } from '@theia/core/shared/inversify';
 import { CommandContribution, MenuContribution } from '@theia/core/lib/common';
-import { OpenHandler, WidgetFactory, FrontendApplicationContribution, KeybindingContext, KeybindingContribution } from '@theia/core/lib/browser';
+import { OpenHandler, WidgetFactory, FrontendApplicationContribution, KeybindingContribution } from '@theia/core/lib/browser';
 import { VariableContribution } from '@theia/variable-resolver/lib/browser';
 import { EditorManager, EditorAccess, ActiveEditorAccess, CurrentEditorAccess } from './editor-manager';
 import { EditorContribution } from './editor-contribution';
 import { EditorMenuContribution } from './editor-menu';
 import { EditorCommandContribution } from './editor-command';
-import { EditorTextFocusContext, StrictEditorTextFocusContext, DiffEditorTextFocusContext } from './editor-keybinding-contexts';
 import { EditorKeybindingContribution } from './editor-keybinding';
 import { bindEditorPreferences } from './editor-preferences';
 import { EditorWidgetFactory } from './editor-widget-factory';
@@ -54,10 +53,6 @@ export default new ContainerModule(bind => {
     bind(EditorMenuContribution).toSelf().inSingletonScope();
     bind(MenuContribution).toService(EditorMenuContribution);
 
-    bind(StrictEditorTextFocusContext).toSelf().inSingletonScope();
-    bind(KeybindingContext).toService(StrictEditorTextFocusContext);
-    bind(KeybindingContext).to(EditorTextFocusContext).inSingletonScope();
-    bind(KeybindingContext).to(DiffEditorTextFocusContext).inSingletonScope();
     bind(EditorKeybindingContribution).toSelf().inSingletonScope();
     bind(KeybindingContribution).toService(EditorKeybindingContribution);
 

packages/editor/src/browser/index.ts

@@ -20,7 +20,6 @@ export * from './editor-widget';
 export * from './editor-manager';
 export * from './editor-command';
 export * from './editor-menu';
-export * from './editor-keybinding-contexts';
 export * from './editor-frontend-module';
 export * from './editor-preferences';
 export * from './decorations';

packages/git/src/browser/blame/blame-contribution.ts

@@ -18,7 +18,7 @@ import { inject, injectable, postConstruct } from '@theia/core/shared/inversify'
 import { KeybindingContribution, KeybindingRegistry } from '@theia/core/lib/browser';
 import { CommandContribution, CommandRegistry, Command, MenuContribution, MenuModelRegistry, DisposableCollection } from '@theia/core/lib/common';
 import { BlameDecorator } from './blame-decorator';
-import { EditorManager, EditorWidget, EditorTextFocusContext, StrictEditorTextFocusContext } from '@theia/editor/lib/browser';
+import { EditorManager, EditorWidget } from '@theia/editor/lib/browser';
 import { BlameManager } from './blame-manager';
 import URI from '@theia/core/lib/common/uri';
 import { EDITOR_CONTEXT_MENU_SCM } from '@theia/scm-extra/lib/browser/scm-extra-contribution';
@@ -185,23 +185,3 @@ export class BlameContribution implements CommandContribution, KeybindingContrib
     }
 
 }
-
-@injectable()
-export class BlameAnnotationsKeybindingContext extends EditorTextFocusContext {
-
-    @inject(BlameContribution)
-    protected readonly blameContribution: BlameContribution;
-
-    @inject(StrictEditorTextFocusContext)
-    protected readonly base: StrictEditorTextFocusContext;
-
-    override id = BlameAnnotationsKeybindingContext.showsBlameAnnotations;
-
-    protected override canHandle(widget: EditorWidget): boolean {
-        return this.base.isEnabled() && this.blameContribution.showsBlameAnnotations(widget.editor.uri);
-    }
-}
-
-export namespace BlameAnnotationsKeybindingContext {
-    export const showsBlameAnnotations = 'showsBlameAnnotations';
-}