Prevent tooltip if no caption is provided and add caption for settings (

#13945)
eclipse-theia · Jul 23, 2024 · 7cbfc7a · 7cbfc7a
1 parent 10f3ff4
commit 7cbfc7a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/core/src/browser/shell/tab-bars.ts b/packages/core/src/browser/shell/tab-bars.ts
@@ -619,7 +619,7 @@ export class TabBarRenderer extends TabBar.Renderer {
  cssClasses: ['extended-tab-preview'],
  visualPreview: this.corePreferences?.['window.tabbar.enhancedPreview'] === 'visual' ? width => this.renderVisualPreview(width, title) : undefined
  });
- } else {
+ } else if (title.caption) {
  this.hoverService.requestHover({
  content: title.caption,
  target: event.currentTarget,

diff --git a/packages/preferences/src/browser/views/preference-widget.tsx b/packages/preferences/src/browser/views/preference-widget.tsx
@@ -78,6 +78,7 @@ export class PreferencesWidget extends Panel implements StatefulWidget {
  protected init(): void {
  this.id = PreferencesWidget.ID;
  this.title.label = PreferencesWidget.LABEL;
+ this.title.caption = PreferencesWidget.LABEL;
  this.title.closable = true;
  this.addClass('theia-settings-container');
  this.title.iconClass = codicon('settings');