Fix plugin version comparison (#13907)

eclipse-theia · Jul 11, 2024 · f12a854 · f12a854
1 parent 62476a0
commit f12a854
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/dev-packages/ovsx-client/src/ovsx-api-filter.ts b/dev-packages/ovsx-client/src/ovsx-api-filter.ts
@@ -90,7 +90,7 @@ export class OVSXApiFilterImpl implements OVSXApiFilter {
  if (extensions.length === 0) {
  return;
  } else if (this.isBuiltinNamespace(extensions[0].namespace.toLowerCase())) {
- return extensions.find(extension => this.versionGreaterThanOrEqualTo(extension.version, this.supportedApiVersion));
+ return extensions.find(extension => this.versionGreaterThanOrEqualTo(this.supportedApiVersion, extension.version));
  } else {
  return extensions.find(extension => this.supportedVscodeApiSatisfies(extension.engines?.vscode ?? '*'));
  }
@@ -108,7 +108,7 @@ export class OVSXApiFilterImpl implements OVSXApiFilter {
  }
  }
  if (this.isBuiltinNamespace(searchEntry.namespace)) {
- return getLatestCompatibleVersion(allVersions => this.versionGreaterThanOrEqualTo(allVersions.version, this.supportedApiVersion));
+ return getLatestCompatibleVersion(allVersions => this.versionGreaterThanOrEqualTo(this.supportedApiVersion, allVersions.version));
  } else {
  return getLatestCompatibleVersion(allVersions => this.supportedVscodeApiSatisfies(allVersions.engines?.vscode ?? '*'));
  }
@@ -127,7 +127,7 @@ export class OVSXApiFilterImpl implements OVSXApiFilter {
  if (!versionA || !versionB) {
  return false;
  }
- return semver.lte(versionA, versionB);
+ return semver.gte(versionA, versionB);
  }
 
  protected supportedVscodeApiSatisfies(vscodeApiRange: string): boolean {