Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open initial electron window early and reuse it later #12897

Merged

Commits on Sep 28, 2023

  1. Open initial electron window early and reuse it later

    This avoids having a rather long pause from Theia start until something
    is visibly coming up. In my initial experiment, I observe the empty
    window showing up ~1.5s earlier than usual.
    
    This behavior can be controlled via the application config in the
    application's package.json. For instance, to turn off, use:
    
    ```
      "theia": {
        "target": "electron",
        "frontend": {
          "config": {
            "applicationName": "Theia Electron Example",
            "electron": {
              "showWindowEarly": false
            }
          }
        }
      }
    ```
    
    Also, we store the background color of the current color theme
    to be able to show the correct background color in the initial
    window.
    
    Contributed on behalf of STMicroelectronics.
    
    Change-Id: Ib8a6e8221c4f48605c865afc120d62adf6eef902
    planger committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f4bf07e View commit details
    Browse the repository at this point in the history