[vscode] Notebook CodeActionKind Support #13093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix missing API CodeActionKind notebook made public on vscode 1.83.
The static kind is available for notebooks, which allows to activate an extension without troubles and to register notebook edit values.
As a remark, the preferences do not align on the current vscode versions for 'editor: Code Actions On Save' possible values. There are no more boolean, but enum (automatic / explicit / etc.).
As a second remark, the save Participant behavior is not yet supported, and the adaptations required for notebook saveParticipants are not yet available. So all adaptations made on vscode issue 192248 cannot be implemented.
Fixes #13059
Contributed on behalf of ST Microelectronics
How to test
notebook-onwillsave-extension-0.0.3.zip
notebook-onwillsave-extension-0.0.3-src.zip
Start browser theia
On activation, the following error is shown:
Switch to the branch and rebuild
Starting with the extension, no more errors shall popup
an action item shall come when in the cell of a notebook editor. I created a 'test.ipynb' file for that with dummy content. The action will add content to the cell when selected.
Follow-ups
Review checklist
Reminder for reviewers