Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nls metadata for vscode API 1.83 #13119

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Nov 29, 2023

What it does

Related to #13118

Uplifts our nls.metadata.json file for the new vscode API version.

How to test

CI is green and localizations work as expected.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Nov 29, 2023
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member

@msujew thanks! I updated the pull-request since I noticed some linting errors after the update 352bafe.

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msujew msujew merged commit bcb9cf7 into master Nov 30, 2023
14 checks passed
@msujew msujew deleted the msujew/nls-metadata-1.83.0 branch November 30, 2023 16:02
@github-actions github-actions bot added this to the 1.44.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants