Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use app shell methods for expand / collapse for toggle terminal command #13131

Merged

Conversation

bryanchenmchp
Copy link
Contributor

@bryanchenmchp bryanchenmchp commented Nov 30, 2023

What it does

Fixes the toggleTerminal() method to use the app shell expand/collapse methods.

Resolves #13129

How to test

  1. Run yarn electron build and then yarn electron start
  2. Press ctrl+` to trigger the "Terminal: Toggle Terminal" command
  3. The bottom panel should animate showing / hiding, this didn't happen before because the bottom panel was directly being shown/hidden

image

Review checklist

Reminder for reviewers

Signed-off-by: Bryan Chen <Bryan.Chen2@microchip.com>
@bryanchenmchp bryanchenmchp changed the title Use app shell methods for expand / collapse Use app shell methods for expand / collapse for toggle terminal command Nov 30, 2023
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected! Thanks!

@tortmayr tortmayr self-requested a review December 13, 2023 14:37
@tortmayr
Copy link
Contributor

@bryanchenmchp There is a conflict in the changelog that needs to be resolved before we can merge this

@bryanchenmchp
Copy link
Contributor Author

Updated changelog

@JonasHelming JonasHelming merged commit c30a79f into eclipse-theia:master Dec 14, 2023
14 checks passed
@bryanchenmchp bryanchenmchp deleted the terminal-use-app-shell-methods branch December 15, 2023 15:02
@vince-fugnitto vince-fugnitto added this to the 1.45.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Toggle Terminal command doesn't use ApplicationShell expand/collapse methods for bottom panel
4 participants