fix unneeded URI conversion #13415
fix unneeded URI conversion #13415
Conversation
|
Seriously.. I went and tried to sign bloody eca.. Whole process is a downer.. And half an hour later it is still not "signed" |
|
@Alexander-Taran Hi, could you describe the issue you faced? Usually that should work within a minute so it would be interesting to learn what went wrong for you. |
and that is all too much for a find and replace commit.. that's a very strong barrier of entry. on top of that, to delete the account I have to write an email.. |
Ah, that's probably the issue. The commit was created with an |
I don't actually |
|
I can understand that setting up a account for contributing a very simple change seems like overhead and it actually is. Even if it has to done only once, of course, it is a entry barrier. Best regards, |
|
@msujew 💤 |
msujew
added
performance
|
Yay!! |
* basics for dev-container support Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * basic creating and connecting to container working Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * open workspace when opening container Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * save and reuse last USed container per workspace Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * restart container if running Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * better container creation extension features Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * added dockerfile support Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * rebuild container if devcontainer.json has been changed since last use Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fix build Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fixed checking if container needs rebuild Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * working port forwarding via exec instance Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * review changes Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fix import Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * smaller fixes and added support for multiple devcontainer configuration files Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * basic output window for devcontainer build Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * smaller review changes and nicer dockerfile.json detection code Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fixed build and docuemented implemented devcontainer.json properties Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * Fix unneeded URI conversion (#13415) * Fix quickpick problems found in IDE testing (#13451) Fixes #13450, #13449 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com> * Fix rending of quickpick buttons (#13342) Ensure that the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item. Fixes #13076 Contributed on behalf of STMicroelectronics * electron: allow accessing the metrics endpoint for performance analysis (#13380) By default, when running Theia in Electron, all endpoints are protected by the ElectronTokenValidator. This patch allows accessing the '/metrics' endpoint without a token, which enables us to collect metrics for performance analysis. For this, ElectronTokenValidator is extended to allow access to the metrics endpoint. All other endpoints are still protected. Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com> * fixed renaming and moving of open notebooks (#13467) * fixed renameing of open notebooks Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fixed moving of notebook editors to other areas Signed-off-by: Jonah Iden <jonah.iden@typefox.io> --------- Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * [playwright] Update documentation Since a recent enhancement/refactoring of @theia/playwright, to permit using it in Theia Electron applications, the way to load an application has changed. This commit is an attempt to update the examples that are part of the documentation. I validated the changes in the "theia-playwright-template" repository, and so I have adapted the sample code to that repo's linting rules (using single quotes instead of double). It's possible that other things have changed, that I have not yet encountered, but this should be a good step forward, at least for those just getting started integrating playwright to test their Theia-based app. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> * basics for dev-container support Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * basic creating and connecting to container working Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * added dockerfile support Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * added port forwarding inlcuding ui Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * basic port/address validation Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fixed allready forwarded port checking Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * rebase fixes Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * removed unused file Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * review changes Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * fixed widget focus and message margin Signed-off-by: Jonah Iden <jonah.iden@typefox.io> * default port binding now shows as 0.0.0.0 Signed-off-by: Jonah Iden <jonah.iden@typefox.io> --------- Signed-off-by: Jonah Iden <jonah.iden@typefox.io> Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com> Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com> Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> Co-authored-by: Alexander Taran <Alexander-Taran@users.noreply.github.com> Co-authored-by: Thomas Mäder <tsmaeder@users.noreply.github.com> Co-authored-by: Tobias Ortmayr <tortmayr@eclipsesource.com> Co-authored-by: Olaf Lessenich <olessenich@eclipsesource.com> Co-authored-by: Marc Dumais <marc.dumais@ericsson.com>
What it does
refactoring of decorations-service
removes unneeded URI -> string ->URI conversion
#13348
How to test
Everything should work as before.
Follow-ups
Review checklist
Reminder for reviewers