Fix FileResource not adding event listener to the disposable collection #13880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivien Jovet <vivien.jovet@torocloud.com>
tsmaeder
approved these changes
Jul 9, 2024
|
@tsmaeder I think you can merge this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR fixes the constructor of FileResource so the listener of
this.fileService.onDidChangeFileSystemProviderReadOnlyMessageis properly disposed when the resource is disposed.Fixes #13877
How to test
You can run the playwright test in examples\playwright\src\tests\theia-application-shell.test.ts. Check the logs, you should not see any emitter memory leak warning related to
onDidChangeFileSystemProviderReadOnlyMessageevent.Review checklist
Reminder for reviewers