Add logging to download:plugins script
#13905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Jul 10, 2024
msujew
approved these changes
Jul 10, 2024
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
13902_download_plugins
branch
from
6f60c21
to
5b86871
Compare
msujew
approved these changes
Jul 11, 2024
| } | ||
| } catch (error) { | ||
| this._searchError = error; |
There was a problem hiding this comment.
Suggestion: We should stringify this error somehow, as _searchError is defined as a string. (while error is any and likely of class Error)
There was a problem hiding this comment.
The equivalent of what we had before would be err?.message || String(err),.
There was a problem hiding this comment.
Yes, that would be preferable. We shouldn't just assign any to string if we don't know what's been thrown.
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds logging to get more info on CI failures descibed in #13902
Contributed on behalf of STMicroelectronics
How to test
Rerun the CI scripts until they fail.
Follow-ups
Review checklist
Reminder for reviewers