Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow opening changes for files associated with custom editors #13916

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Allow opening changes for files associated with custom editors #13916

merged 7 commits into from
Aug 21, 2024

Commits on Aug 7, 2024

  1. Fix loading of webview resources that depend on query params 

    Some resource url (notably git) use the query part of the url to store
additional information. The query part of the url was incorrectly being
dropped while attempting to load these resources inside of webviews.

See also microsoft/vscode@48387df
    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1553f70 View commit details
    Browse the repository at this point in the history

  2. Fix Error: Unknown Webview messages in the log

    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    097405c View commit details
    Browse the repository at this point in the history

  3. Fix design and implementation issues surrounding CustomEditorOpener 

    This commit ensures that the promise returned by `CustomEditorOpener.open`
will only resolve to a properly initialized and opened `CustomEditorWidget`.
In particular, it ensures that the widget is opened according to the specified
`WidgetOpenerOptions`, including `widgetOptions.ref` and `mode`.

Essentially, it revises the work done in eclipse-theia#9671 and eclipse-theia#10580
to fix eclipse-theia#9670 and eclipse-theia#10583.
    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    91113b8 View commit details
    Browse the repository at this point in the history

  4. Restore custom editors as part of layout 

    Fixes an incorrect assumption that a custom editor cannot be restored
if no `WebviewPanelSerializer` is registered for its view type. (Actually,
custom editors are created and restored using a custom editor provider.)

Also, ensures that `CustomEditorWidget.modelRef` satisfies the shape for the
`CustomEditorWidget` defined in `editor.ts` and cannot return `undefined`.
(However, `CustomEditorWidget.modelRef.object` can be `undefined`
until the custom editor is resolved.)

Fixes eclipse-theia#10787
    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    14719f8 View commit details
    Browse the repository at this point in the history

  5. Fix a race condition when file system provider is activated 

    When file system provider is activated, wait until it is registered.
    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c8d1b95 View commit details
    Browse the repository at this point in the history

  6. git: add support for custom editors 

    * Uses `OpenerService` instead of `EditorManager` to open editors

* Contributes a `FileSystemProvider` for git-resources

* Fixes an issue with getting blob contents
    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5392e2d View commit details
    Browse the repository at this point in the history

  7. custom editor: open a diff-uri in a side-by-side editor 

    `CustomEditorOpener` is now able to open a diff-uri in a side-by-side editor,
which contains the corresponding `CustomEditor`s.

Fixes eclipse-theia#9079
    @pisv
    pisv committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    90e6932 View commit details
    Browse the repository at this point in the history