Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for "--headless-hosted-plugin-inspect" cmd argument #13918

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Support for "--headless-hosted-plugin-inspect" cmd argument #13918

merged 4 commits into from
Aug 5, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Jul 12, 2024 •
edited
Loading

What it does

  • add names for plugin servers that will be used on the command line like --server-name-inspect
  • enable --headless-hosted-plugin-inspect
  • add plugin-dev preferences for specifying ports per plugin-server via the new server-name

closes #13462

How to test

See instructions on the ticket #13462

Follow-ups

Review checklist

Reminder for reviewers

@jfaltermeier
Support for "--headless-hosted-plugin-inspect" cmd argument #13462
55c7385 
* allow to pass down server name to HostedPluginServer from
AbstractHostedPluginSupport
* pass down either hosted-plugin or headless-hosted-plugin
* add preferences to specify node js debug ports per hosted plugin
server
* adjust PluginDebugConfiguration to also accept and array of
server-name to debug port entries
@jfaltermeier
Support for "--headless-hosted-plugin-inspect" cmd argument #13462
57ea516 
* refactor to directly set servername on backend instead of handing it
down from frontend
martin-fleck-at
martin-fleck-at requested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me and works very well, thank you Johannes! I do have a few questions and some small nitpicks but nothing major.

packages/plugin-ext/src/hosted/node/hosted-plugin-process.ts Outdated Show resolved Hide resolved
packages/plugin-ext/src/hosted/node/plugin-service.ts Outdated Show resolved Hide resolved
packages/plugin-dev/src/browser/hosted-plugin-manager-client.ts Outdated Show resolved Hide resolved
packages/plugin-dev/src/browser/hosted-plugin-manager-client.ts Outdated Show resolved Hide resolved
martin-fleck-at
martin-fleck-at approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick update! Change looks good to me.

@jfaltermeier jfaltermeier merged commit effb3ec into master Aug 5, 2024
14 checks passed
@jfaltermeier jfaltermeier deleted the jf/issues/13462_inspect branch August 5, 2024 14:08
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Need support for a "--headless-hosted-plugin-inspect" backend cmdline argument
2 participants
@jfaltermeier @martin-fleck-at