Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dead README links #13931

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

danielledeleo
Copy link
Contributor

What it does

Fixes a few bit rotted links. All of the pages still existed, but were renamed.

How to test

Follow-ups

Existing link checker pipelines should be updated to include the GitHub README.

Review checklist

Reminder for reviewers

Signed-off-by: Danielle De Leo <danielle@fastmail.net>
@danielledeleo
Copy link
Contributor Author

Screenshot 2024-07-16 at 8 17 22 AM

As much as I'd love to chase down this CI failure, I don't care anymore. I did sign the DCO.

@msujew
Copy link
Member

msujew commented Jul 16, 2024

Hey @danielledeleo, thanks for the contribution! The ECA tells me that there's no Eclipse account associated with the email address that was used to create the commit you submitted:

image

Maybe you've signed the ECA for a different email? Unfortunately, we cannot accept changes without going through the ECA due to legal reasons.

@danielledeleo
Copy link
Contributor Author

Screenshot 2024-07-16 at 8 23 46 AM

@msujew msujew reopened this Jul 16, 2024
@msujew
Copy link
Member

msujew commented Jul 16, 2024

Seems like the Eclipse servers didn't update the ECA check correctly. It's working now 👍

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix 👍

@msujew msujew merged commit 8ad18ea into eclipse-theia:master Jul 16, 2024
15 checks passed
@msujew msujew added the documentation issues related to documentation label Jul 16, 2024
@sgraband sgraband added this to the 1.52.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants