Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change cell type when selecting markdown as a code cells language #13933

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Changes the cell type to a markdown cell when markdown is selected via the language picker in the bottom right of a code cell.

How to test

  1. Open or create a new notebook.
  2. Add a code cell and optionally write something inside
  3. change its language to markdown via the language picker in the bottom right
  4. it should correctly change to a markdown retaining the previous content and have the ability to render the markdown

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew July 17, 2024 10:00
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Currently we don't have a way to go the reverse direction (i.e. from markdown -> code), but that's out of scope for this PR.

@jonah-iden
Copy link
Contributor Author

yeah at some point we probably need to add language selection for makrdown cell as well. There is a command/keybinding to change markdown cell to code cell and back though

@jonah-iden jonah-iden merged commit 9e9a9f1 into master Jul 17, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.52.0 milestone Jul 17, 2024
@jonah-iden jonah-iden deleted the jiden/notebook-chang-cell-type-markdown branch July 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants