Introduce environment variable to override connexion settings #13936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration fixes eclipse-theia#13800 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
remi/13800_connection_settings
branch
from
a82987a
to
2cbcb10
Compare
planger
approved these changes
Jul 17, 2024
packages/core/src/node/messaging/websocket-frontend-connection-service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Langer <planger@eclipsesource.com>
|
Thanks for this very quick review and suggestions, @planger! I still don't understand why we have different spelling for "connection" in French and English :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds support for a
FRONTEND_CONNECTION_TIMEOUTenvironment variable to override configuration setting for the backend.fixes #13800
Contributed on behalf of STMicroelectronics
How to test
yarn browser startfrom terminal). Open a browser window and accesslocalhost:3000setting close timeout for id fb80451d-10da-416b-b656-062c78ba408a to 3000export FRONTEND_CONNECTION_TIMEOUT=10000-1, closing directly the connection or with something else than a number. It should then turn back to default config, e.g. 3000.Follow-ups
none
Review checklist
Reminder for reviewers