Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add border and fix indentation for editable markdown cell #13947

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add border and fix indentation for editable markdown cell #13947

merged 1 commit into from
Jul 25, 2024

Conversation

dhuebner
Copy link
Contributor

@dhuebner dhuebner commented Jul 24, 2024 •
edited
Loading

What it does

Some notebook related fixes:

  1. Fixes missing border in markdown cell when editing. Also adjusted indentation to align with Code Cells

Before:
Bildschirmfoto 2024-07-24 um 13 45 05

After:
Bildschirmfoto 2024-07-24 um 13 45 26

How to test

Open a notebook file and verify that the points above are solved.

Follow-ups

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Jul 24, 2024
msujew
msujew reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is still a draft? The changes look pretty good to me.

@dhuebner dhuebner marked this pull request as ready for review July 25, 2024 08:10
@dhuebner
Copy link
Contributor Author

@msujew
I thought I can put more improvements, but it is better to do it one by one.
Ready for re-view.

msujew
msujew approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me 👍

@msujew msujew merged commit 3ffc717 into eclipse-theia:master Jul 25, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhuebner @msujew