Refactor undo-redo action for editors #13963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13962
Closes #9344
Refactors our undo/redo mechanism to better support different kinds of editors. Adds a
UndoRedoHandlerService
that keeps a list ofUndoRedoHandler
contributions. This design is heavily influenced by how VS Code handles its undo/redo across different editors. See also microsoft/vscode#98288.How to test
Follow the reproduction steps from #13962 and #9344 and assert that the undo/redo action is only ever executed on the currently selected editor. Also:
Follow-ups
Using this architecture, we could add support to undo/redo actions in the navigator. VS Code for example allows to undo file deletion/rename/move. We can do that in a separate PR though.
Review checklist
Reminder for reviewers