Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ChannelMultiplexer in RPCProtocol #13980

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Aug 1, 2024

What it does

The use of a ChannelMultiplexer in RPCProtocol was causing the sending of request from the plugin host to be delayed until a sub-channel could be opened. This would lead to the reply for the request that caused the "callback" to the front end to be sent before the request from the plugin host.
This PR removes the channel multiplexer from the RPCProtocol and instead just sends the proxy id as an additional parameter.

Fixes #13960

Contributed on behalf of STMicroelectronics

How to test

Since this PR fixes a problem discovered in #13306, we'll need that on to be merged in order to test that the issue is actually fixed. What we can test right now, though, is that the change does not cause any trouble for the operation of plugins. This means using plugins and observing the logs, etc.

Follow-ups

The startup sequence for plugins hosts is still not entirely deterministic. Some of the ideas in #8437 would still be worth reviving in new PR, even though we don't run into any timing problems, currently.

Review checklist

Reminder for reviewers

Fixes eclipse-theia#13960

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder
Copy link
Contributor Author

@msujew this one would be good to get merged soon to get the code exercised a bit before the next release. @tortmayr is on vacation until the next week.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can confirm that extension features still work as expected (tested with TypeScript & Jupyter). Less code is always better :)

@msujew msujew added the messaging issues related to messaging label Aug 12, 2024
@tsmaeder tsmaeder merged commit 817c1a0 into eclipse-theia:master Aug 13, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.53.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
messaging issues related to messaging
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cannot Register URI Handler in Activation Event
3 participants