Support find widget in notebooks #13982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds support for a monaco-like find widget to the notebook widget.
How to test
The search widget can be brought up by pressing
Ctrl+F
inside of any area of the notebook widget. Having the Jupyter Keymaps extension installed also allows to bring it up by just pressingF
outside of an editor area (while the notebook widget is focused).Multiple test scenarios:
Ctrl+F
. The selected text should be placed as the initial search value of the find widget.Follow-ups
Known issues:
The current API is pretty suboptimal (especially for finding matches inside of rendered markdown cells). I plan to get back to this later to revise the API and extract a common
FindWidget
that can be used by any widget.Review checklist
Reminder for reviewers