-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook output optimization #14234
base: master
Are you sure you want to change the base?
notebook output optimization #14234
Conversation
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
76ea74b
to
10a5c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive! The notebook editor is now way more responsive and a lot of the bugs (like output disappearing on moving cells, etc.) are now fixed. However, I found some issues/regressions with the changes:
- Some outputs cannot be rendered after reopening a notebook. I don't think we can fix this (VS Code also cannot, see this image). However, this leads to miscalculations in the output renderer logic and everything seems to be misaligned:
- Clicking on a rendered Markdown cell (non-editing mode) does not focus the cell. One has to click on the sidebar of the cell instead. AFAIK this is a regression from the current
master
branch. - Closing a notebook editor takes a surprising amount of time. In some cases more than a second. During this time, the application seems to freeze up. I can pretty consistently reproduce this using this notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuing the issues above:
- I've noticed some jittering in the layout while scrolling through a larger notebook. The editors seem to have a "second layout" phase where they increase their size by a few pixels. This leads to a lot of jittering during the scrolling due to resizing editors. IIRC this is also the case on
master
, so treat this as a low-prio issue for now.
packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I found another (pretty weird) issue:
- Open a notebook and clear one cell output (the document becomes dirty)
- Close the notebook (it doesn't matter whether you save the changes)
- Reopen the notebook - no outputs are visible
- Closing and reopening the notebook fixes the issue (?)
What it does
Changes the notebook output rendering to only use a single webview for each editor.
This should also fix some previously existent issues like with moving cells having outputs and changing mime type.
How to test
Open a notebook and test that everything regarding rendering of outputs still works.
Follow-ups
Review checklist
Reminder for reviewers