Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert third-party code note into an acknowledgment section #78

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Dec 1, 2023

As discussed in today's committer meeting, this PR converts the node on third-party code from node-wot into a more fitting acknowledgment of node-wot.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b52a03b) 52.28% compared to head (0ead1b8) 52.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   52.28%   52.28%           
=======================================
  Files          70       70           
  Lines        2184     2184           
=======================================
  Hits         1142     1142           
  Misses       1042     1042           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danielpeintner

This comment was marked as resolved.

@JKRhb JKRhb enabled auto-merge December 1, 2023 13:44
@JKRhb JKRhb merged commit f3e39bf into main Dec 1, 2023
4 checks passed
@JKRhb JKRhb deleted the third-party-license branch December 1, 2023 13:46
Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants