Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(charts): add default value descriptions to the README #936

Merged
merged 1 commit into from
May 24, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented May 22, 2024

Description

This pull request updates the chart READMEs with default values descriptions

Fixes #925

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow force-pushed the docs/charts/default-values branch from 37fb531 to 0269d71 Compare May 22, 2024 15:04
@nicoprow nicoprow force-pushed the docs/charts/default-values branch from 0269d71 to 021ef69 Compare May 22, 2024 15:06
@nicoprow nicoprow requested a review from hzierer May 23, 2024 07:04
@nicoprow nicoprow marked this pull request as ready for review May 23, 2024 07:04
Copy link

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the DEPENDENCIES file - the rest LGTM.

charts/bpdm/Chart.yaml Show resolved Hide resolved
@hzierer hzierer mentioned this pull request May 24, 2024
37 tasks
@nicoprow nicoprow merged commit 127b231 into main May 24, 2024
8 checks passed
@nicoprow nicoprow deleted the docs/charts/default-values branch May 24, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRG 5.02] Charts README.md file is lacking info about default values
2 participants