Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make pom more CI friendly by using Maven revision property #971

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jun 20, 2024

Description

This pull request makes the maven build more CI friendly and eases the effort when upgrading the BPDM app version.

  • include revision property in parent pom
  • child modules now refer to parent pom version by revision property
  • also clean pom dependencies

for more info visit https://maven.apache.org/maven-ci-friendly.html

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow force-pushed the build/ci-friendly-maven branch 3 times, most recently from eaf7777 to 2f8138c Compare June 20, 2024 10:13
@nicoprow
Copy link
Contributor Author

- include revision property in parent pom
- child modules now refer to parent pom version by revision property
- also clean pom dependencies

for more info visit https://maven.apache.org/maven-ci-friendly.html
@nicoprow
Copy link
Contributor Author

Issues Resolved

@nicoprow nicoprow marked this pull request as ready for review July 16, 2024 10:27
@nicoprow nicoprow requested a review from SujitMBRDI July 16, 2024 10:27
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more need change and IP lab approved too

@SujitMBRDI SujitMBRDI assigned nicoprow and unassigned SujitMBRDI Jul 17, 2024
@nicoprow nicoprow merged commit c16826f into main Jul 18, 2024
16 checks passed
@nicoprow nicoprow deleted the build/ci-friendly-maven branch July 18, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants