feat(impl): [#639] fix broken tests after merge

eclipse-tractusx · Jul 23, 2024 · 01fef00 · 01fef00
1 parent 3a8f43e
commit 01fef00
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/irs-policy-store/src/main/java/org/eclipse/tractusx/irs/policystore/common/DateUtils.java b/irs-policy-store/src/main/java/org/eclipse/tractusx/irs/policystore/common/DateUtils.java
@@ -50,6 +50,9 @@ public static boolean isDateBefore(final OffsetDateTime dateTime, final String r
     }
 
     public static boolean isDateAfter(final OffsetDateTime dateTime, final String referenceDateString) {
+        if (StringUtils.isBlank(referenceDateString)) {
+            throw new IllegalArgumentException("Invalid date: must not be blank!");
+        }
         if (isDateWithoutTime(referenceDateString)) {
             return dateTime.isAfter(toOffsetDateTimeAtEndOfDay(referenceDateString));
         } else {
@@ -99,7 +102,7 @@ public static boolean isDateWithoutTime(final String referenceDateString) {
             return false;
         } catch (DateTimeParseException e) {
             log.trace(e.getMessage(), e);
-            throw new IllegalArgumentException("Invalid date format: " + referenceDateString);
+            throw new IllegalArgumentException("Invalid date format: " + referenceDateString, e);
         }
     }
 }
diff --git a/...policy-store/src/test/java/org/eclipse/tractusx/irs/policystore/common/DateUtilsTest.java b/...policy-store/src/test/java/org/eclipse/tractusx/irs/policystore/common/DateUtilsTest.java
@@ -117,16 +117,14 @@ public void testIsDateWithoutTimeWithInvalidDate() {
     }
 
     @ParameterizedTest
-    @ValueSource(strings = { "3333-11-11T11:11:11.111Z",
-                             "3333-11-",
+    @ValueSource(strings = { "3333-11-",
                              "2222",
                              "asdf"
     })
     void testInvalidDate(final String referenceDateStr) {
         final ThrowingCallable call = () -> DateUtils.isDateAfter(OffsetDateTime.now(), referenceDateStr);
         assertThatThrownBy(call).isInstanceOf(IllegalArgumentException.class)
                                 .hasMessageContaining("Invalid date")
-                                .hasMessageContaining("refer to the documentation")
                                 .hasCauseInstanceOf(DateTimeParseException.class);
     }