Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Megre from catena-x #276

Merged
merged 39 commits into from
Nov 14, 2023
Merged

Megre from catena-x #276

merged 39 commits into from
Nov 14, 2023

Conversation

ds-psosnowski
Copy link
Contributor

@ds-psosnowski ds-psosnowski commented Nov 13, 2023 •
edited
Loading

Description

Merge changes from catena-x.

  • IRS can now check the readiness of external services. Use the new management.health.dependencies.enabled config entry to determine if external dependencies health checks should be checked (false by default).
    • The map of external services healthcheck endpoints can be configured with management.health.dependencies.urls property, eg. service_name: http://service_name_host/health
  • Added cache mechanism for ConnectorEndpointService for fetchConnectorEndpoints method cache
  • Updated commit message format check to match github pattern

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

ds-ext-kmassalski and others added 30 commits October 30, 2023 15:35
@ds-ext-kmassalski
feat(impl):[TRI-1657] adjustments after review
b7957af
@ds-alexander-bulgakov
TRI-1657: changed expected tombstone in tavern test
86404f3
@ds-alexander-bulgakov
Merge pull request #616 from catenax-ng/feature/TRI-1657-change-error…
9dc4d48 
…-detail

feat(impl):[TRI-1657] adjustments after review
@mkanal
Add codeFormatter to CONTRIBUTION
16ee657
@mkanal
Update CONTRIBUTING.md
2624d12
@mkanal
Update CONTRIBUTING.md
32425ef
@ds-psosnowski
feat(impl):[210] added cache mechanism to ConnectorEndpointsService
310834a
@ds-psosnowski
feat(impl):[210] added missing value
585af85
@ds-ext-kmassalski
feat(impl):[TRI-205] external dependencies healtchecks impl
aa34db8
@ds-ext-kmassalski
Merge pull request #620 from catenax-ng/chore(CONTRIBUTION)TRI-XXX]-a…
1bfd4f1 
…dd-code-Formatting-to-contribution

Add codeFormatter to CONTRIBUTION
@ds-ext-kmassalski
chore(dependencies): Update DEPENDENCIES
cb27882
@ds-ext-kmassalski
feat(impl):[TRI-205] unit test
e601fac
@ds-ext-kmassalski
Merge pull request #625 from catenax-ng/chore/update-DEPENDENCIES
b208c6e 
Update DEPENDENCIES
@ds-ext-kmassalski
feat(impl):[TRI-205] unit test
1706bc2
@mkanal
chore(doc):[#204] reorganize code
46de694
@ds-psosnowski
feat(impl):[210] removed code smells
ca5b276
@mkanal
chore(doc):[#204] add ess basic documentation and structure
45fbc9c
@mkanal
chore(docs):[#204] add description for high level view
77c2496
@mkanal
fix(docs):[#204] remove unused heading
a302f4a
@ds-psosnowski
Merge pull request #623 from catenax-ng/TRI-210-add-cache-for-bpnl-en…
56ac9e4 
…dpoints

feat(impl):[210] added cache mechanism to ConnectorEndpointsService
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
da4585a
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
ddb2e77
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
f9b552a
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
95d801b
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
b9b5057
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
cbe1605
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
b78665e
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
f455e98
@ds-ext-kmassalski
feat(impl):[TRI-224] changelog check workflow action
6a0ccce
@ds-jhartmann
chore(docs):[#204] Minor adjustments to formatting after review
79e873c
ds-ext-kmassalski and others added 9 commits November 10, 2023 10:51
@ds-ext-kmassalski
feat(impl):[TRI-205] update changelog
4b41b0d
@mkanal
Merge pull request #626 from catenax-ng/chore/#204-Runtime-view-adapt…
1985c2a 
…ions-for-ESS-UseCase

Chore/#204 runtime view adaptions for ess use case
@ds-ext-kmassalski
feat(impl):[TRI-224] include review comment
e8f5c78
@ds-jhartmann
Merge pull request #630 from eclipse-tractusx/main
0160ab6 
Sync with upstream
@ds-ext-kmassalski
Merge pull request #628 from catenax-ng/feature/TRI-224-workflow-to-c…
369470b 
…heck-changelog

feat(impl):[TRI-224] changelog check workflow action
@ds-ext-kmassalski
feat(impl):[TRI-205] merge main
f270b85
@ds-ext-kmassalski
feat(impl):[TRI-205] fix lint
d5ac243
@ds-ext-kmassalski
Merge pull request #624 from catenax-ng/feature/TRI-205-external-depe…
2c1d9e1 
…ndencies-healthchecks

feat(impl):[TRI-205] external dependencies healtchecks impl
@ds-psosnowski
feat(git):[#000] Updated commit msg git hook checkstyle
1b81996
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2023
View reviewed changes
.github/workflows/changelog-changes.yaml

- name: Create or update comment in PR
if: steps.changelog-changed.outputs.any_changed == 'false'
uses: peter-evans/create-or-update-comment@v3

Check warning

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Warning

Action is not pinned to a full length commit SHA.
.github/workflows/changelog-changes.yaml

- name: Find previous comment in PR
if: steps.changelog-changed.outputs.any_changed == 'false'
uses: peter-evans/find-comment@v2

Check warning

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Warning

Action is not pinned to a full length commit SHA.
.github/workflows/changelog-changes.yaml

- name: Check if CHANGELOG file was changed
id: changelog-changed
uses: tj-actions/changed-files@v40

Check warning

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Warning

Action is not pinned to a full length commit SHA.
ds-jhartmann
ds-jhartmann approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit d9ae84e into eclipse-tractusx:main Nov 14, 2023
18 of 19 checks passed
@ds-jhartmann ds-jhartmann deleted the feature/update-commit-message-pattern branch November 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

@ds-ext-kmassalski ds-ext-kmassalski Awaiting requested review from ds-ext-kmassalski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ds-psosnowski @ds-jhartmann @ds-ext-kmassalski @ds-alexander-bulgakov @mkanal