Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: make repository release ready #51

Merged
merged 17 commits into from
Jul 11, 2024

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Jul 8, 2024

WHAT

Extends the chart with a mapping domain section and include a portion of the traceability domain as an example.
Stabilize the probes to use the builtin busybox wget and deal with self-signed certificates.
Upgrades some compilation and CICD pipeline dependencies to the latest versions (as suggested by dependabot).
Does some copyright period adjustments.

WHY

Repository becomes release, integration-test and e2e-test ready.

FURTHER NOTES

needs to wait for #49 as it puts changes on top. Also adjusts some requirements from there since the source repo went stale.

Closes #6 <-- insert Issue number if one exists

@drcgjung drcgjung added the documentation Improvements or additions to documentation label Jul 8, 2024
@almadigabor
Copy link
Contributor

Hey @drcgjung,

  • I've opened the IP issue and it can be tracked here
  • The DEPENDENCIES file contains some restricted libraries, I'll open tickets for them then the file needs to be updated.

@almadigabor
Copy link
Contributor

Here is the output of the dash-tool run:

[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-base/5.0.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15685 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-core/5.0.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15686 .
[INFO] A review is required for maven/mavencentral/org.apache.thrift/libthrift/0.19.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15687 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-shacl/5.0.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15688 .
[INFO] A review is required for maven/mavencentral/de.fraunhofer.iosb.ilt.faaast.service/endpoint-opcua/1.0.1.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15689 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-arq/5.0.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15690 .
[INFO] A review is required for maven/mavencentral/de.fraunhofer.iosb.ilt.faaast.service/starter/1.0.1.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15691 .

@drcgjung
Copy link
Contributor Author

Hey @drcgjung,

* I've opened the IP issue and it can be tracked [here](https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15684)

* The DEPENDENCIES file contains some restricted libraries, I'll open tickets for them then the file needs to be updated.

Most of the changes where copyright things. The actual "logic" changes where in the chart. Do we really need an IP check on that?

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest change is in the sparql-aas/src/test/resources/exampleAasEnvs/partSiteInformation.xml file. Unfortunately if it’s a contribution from outside the eclipse-tractusx org and there are more than 1000 lines of changes an IP issue has to be created.

Let's wait for the IP issue and dependency checks then it looks good from my side.

@almadigabor
Copy link
Contributor

Looks like all dependencies have been approved, you can update the DEPENDENCIES file.

@almadigabor almadigabor merged commit 66ad98b into eclipse-tractusx:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Story "Upgrade AAS4J"
3 participants