feat(ssi): Issuer component re issuance of bpnl and membership credentials #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-Re-issuance-of-BPNL-and-Membership-Credentials
…mbership-Credentials' of https://github.com/leandro-cavalcante/ssi-credential-issuer into feat/CS-948-Issuer-Component-Re-issuance-of-BPNL-and-Membership-Credentials
…mbership-Credentials' of https://github.com/leandro-cavalcante/ssi-credential-issuer into feat/CS-948-Issuer-Component-Re-issuance-of-BPNL-and-Membership-Credentials
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/credentials/SsiCredentialIssuer.Reissuance.App/Services/ReissuanceService.cs
Fixed
Show resolved
Hide resolved
src/credentials/SsiCredentialIssuer.Reissuance.App/Services/ReissuanceService.cs
Fixed
Show fixed
Hide fixed
src/processes/CredentialProcess.Library/Reissuance/CredentialReissuanceProcessHandler.cs
Fixed
Show resolved
Hide resolved
tests/credentials/SsiCredentialIssuer.Reissuance.App.Tests/Services/ReissuanceServiceTests.cs
Fixed
Show fixed
Hide fixed
leandro-cavalcante
changed the title
leandro-cavalcante
changed the title
leandro-cavalcante
changed the title
Phil91
requested changes
Sep 2, 2024
There was a problem hiding this comment.
@leandro-cavalcante I have made some changes to your branch, but can't currently push to your repo due to permission issues. The changes can be found here: fce37a1
I've put them in one commit so it should be easy to integrate within your branch. Please have a look at that.
|
|
||
| reissuanceRepository.CreateReissuanceProcess(credentialRequest.Id, ssiDetailId); | ||
|
|
||
| companyCredentialDetailsRepository.CreateProcessData(ssiDetailId, JsonDocument.Parse(credentialRequest.Schema), credentialRequest.KindId, |
There was a problem hiding this comment.
this will not work with the current process. It will fail when trying to import the created credential to the holder wallet, because we need the auth data for that. In the current api implementation when creating the credential the auth data are send within the request of the creation.
…t-Re-issuance-of-BPNL-and-Membership-Credentials
Comment on lines
+65
to
+69
| catch (Exception ex) | ||
| { | ||
| Environment.ExitCode = 1; | ||
| logger.LogError(ex, "Verified Credential re-issuance check failed with error: {Errors}", ex.Message); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
MaximilianHauer
added
the
merge postponed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development of an automated backend logic inside the issuer component for the re-issuance of BPNL and Membership credentials prior to their expiration. The system will incorporate a scheduled job to run nightly, identifying credentials expiring the next day and re-issuing them automatically, while adhering to defined business rules and workflows.
Why
A creation of a new Reissuance service and related process were created in order to fulfill the requirements of reissuing a new credential when the actual credential is about to expire.
Issue
Link to Github issue.
Checklist
Please delete options that are not relevant.